Comments on: Fluent NHibernate: Conventions Rewrite

By: Rolling my own blog engine, part 3 — CarlFurrow.com

Rolling my own blog engine, part 3 — CarlFurrow.com — Tue, 02 Jun 2009 02:30:08 +0000

[...] A simplistic line of code, but it actually does quite a bit as we’ll soon find out. Now that we’ve told Fluent NHibernate Automapping how to find DTOs to map to database tables, we now would like to tell it what to do with them by defining some conventions. See James Gregory’s quick overview to the convention framework by visiting his blog. [...]

By: James Gregory

James Gregory — Mon, 30 Mar 2009 16:59:21 +0000

Hi Mark, sorry but your comment got stuck in comment-limbo. Your points are great and those two conventions should be included in the Wiki. I'd recommend you pop by the mailing list if you're in need of any help.

By: Mark

Mark — Tue, 24 Mar 2009 12:59:44 +0000

Hi – I agree with the convention changes and feel this is definitely a step in the right direction.
I am only just starting to use FluentNhibernate and only just got to grips with the previous conventions though and how these were implemented. To get me on the right track could you advise how the following would be implemented using the above technique:

.WithConventions(c =>
{

c.GetForeignKeyName = type => type.Name + “Id”;
c.GetForeignKeyNameOfParent = type => type.Name + “Id”;})

I know you have to use the IHasManyCollection but not sure the best way to approach it – I know it is probably very simple but any help appreciated. This would probably be useful as another example in Wiki as it a commonly used convention and its not initially obvious how to use the new conventions to acheive this. Great project by the way..

By: James Gregory

James Gregory — Mon, 16 Mar 2009 08:19:30 +0000

Hey Peter, I’m very flattered you think I’ve got a book in me; once the code-base stabilises and we start catching up to hbm.xml in features then I’d certainly be open to the possibility. We’ll see what the future holds.

By: Peter Bromberg

Peter Bromberg — Mon, 16 Mar 2009 01:42:24 +0000

James: It’s time for a book. Manning would probably be interested. Get a co-author if needed. Get the code baked, write the book! I’ll be the first to buy it and write a review on our site. You have the skills and your writing style is perfect for this. How about it?

By: Ben Scheirman

Ben Scheirman — Fri, 13 Mar 2009 11:57:44 +0000

Man, this is a LOT better. Well done, James!

By: James Gregory

James Gregory — Thu, 12 Mar 2009 09:37:42 +0000

Thanks Harry, corrected. Take a look at the conventions shortcuts which uses an underlying delegate convention.

By: Harry M

Harry M — Thu, 12 Mar 2009 09:31:04 +0000

James, you ahve a typo
public bool Apply(IClassMap classMap)
{
// will produce table names like: tbl_Customer, tbl_Product
classMap.WithTable(“tbl_” + classMap.EntityType.Name);
}

wither this method is meant to be void or its missing a return value.

Why not create a DelegateConvention like

public class DelegateConvention : IClassConvention
{
public DelegateConvention(Func accept, Action action){…}
…
}